feat: [M3-8005] – Add disk_encryption to types & validation schemas
#10413
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwiley-akamai
added
@linode/api-v4
dwiley-akamai
force-pushed
the
M3-8005-types-updates-for-lde
branch
from
d70c4f6 to
17d34d1
Compare
|
Is there a justification for using |
I can't go into much detail here (see page 6 of the spec for more in-depth discussion on it by members of the API team), but essentially it has to do with future-proofing. |
dwiley-akamai
requested review from
cpathipa and
abailly-akamai
and removed request for
a team
…uest, RebuildRequest, and KubeNodePoolResponse interfaces
…buildLinodeSchema
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Apr 26, 2024
abailly-akamai
approved these changes
Apr 29, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add
disk_encryptionto types & validation schemas as appropriate based on the API spec (see ticket for link)Changes 🔄
EncryptionStatustype added;disk_encryptionfield added toLinode,Disk,CreateLinodeRequest, andRebuildRequestinterfacesdisk_encryptionadded toCreateLinodeSchemaandRebuildLinodeSchema; it is nullable and optional, but if provided should have a value of either "enabled" or "disabled"Note
@TODO LDE: remove optionality once LDE is fully rolled outwas added as a comment to a few new properties. These are instances where, when LDE is fully rolled out,disk_encryptionwill always be included on that object. I think marking them as optional at this point is fair because not doing so would be premature, and also likely confuse consumers of the JS Client.Target release date 🗓️
5/13/24
How to test 🧪
Verification steps
disk_encryptionfield)As an Author I have considered 🤔